Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deps): Restructure into checks/ #41

Merged
merged 7 commits into from
Dec 8, 2023
Merged

refactor(deps): Restructure into checks/ #41

merged 7 commits into from
Dec 8, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Nov 29, 2023 •
edited
Loading

@simar7 simar7 force-pushed the rename-to-checks branch 2 times, most recently from 20f0d23 to bda1e8b Compare December 6, 2023 05:46
@simar7 simar7 marked this pull request as ready for review December 6, 2023 05:52
@simar7
Copy link
Member Author

simar7 commented Dec 6, 2023

TODO: This will require relocation of the following

image image

@nikpivkin
Copy link
Contributor

LGTM, but:

I think document-related commands can be deleted:

.PHONY: id
id:
	@go run ./cmd/id

.PHONY: docs
docs:
	go run ./cmd/avd_generator

.PHONY: docs-test
docs-test:
	go test -v ./cmd/avd_generator/...

@simar7
Copy link
Member Author

simar7 commented Dec 7, 2023

LGTM, but:

I think document-related commands can be deleted:

.PHONY: id
id:
	@go run ./cmd/id

.PHONY: docs
docs:
	go run ./cmd/avd_generator

.PHONY: docs-test
docs-test:
	go test -v ./cmd/avd_generator/...

Yes I've moved them here aquasecurity/avd-generator#79 - I will remove the targets from here.

@simar7
Copy link
Member Author

simar7 commented Dec 7, 2023 •
edited
Loading

TODO: This will require relocation of the following

image image

As for the code under cmd/, I've added it here: aquasecurity/avd-generator#79

As for the tests:

  1. bundle_test.go was brought back be42420
  2. rules_test.go was moved here aquasecurity/avd-generator@143b103
  3. I think we can scrap docker_test.go as I don't see much value in keeping it.

@simar7 simar7 merged commit 54235f7 into main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simar7 @nikpivkin