refactor(redhat-oval): return an error if the CPE is not found #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Sep 2, 2024
| @@ -248,6 +248,10 @@ func (vs VulnSrc) Get(pkgName string, repositories, nvrs []string) ([]types.Advi | |||
| return nil, xerrors.Errorf("CPE convert error: %w", err) | |||
| } | |||
|
|
|||
| if len(cpeIndices) == 0 { | |||
| return nil, xerrors.Errorf("No CPE indices found") | |||
There was a problem hiding this comment.
Suggested change
| return nil, xerrors.Errorf("No CPE indices found") | |
| return nil, xerrors.Errorf("no CPE indices found") |
There was a problem hiding this comment.
And this error message is unclear. What do you think about adding this issue to the error message?
#435
There was a problem hiding this comment.
It make sense.
Updated in 83716e8
knqyf263
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get()function returns an error if the CPE is not found