perf: avoid heap allocation in applier findPackage (#7883)

Co-authored-by: knqyf263 <knqyf263@gmail.com>
aquasecurity · Dec 9, 2024 · 9bd6ed7 · 9bd6ed7
1 parent 2c41ac8
commit 9bd6ed7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/fanal/applier/docker.go b/pkg/fanal/applier/docker.go
@@ -31,9 +31,10 @@ type History struct {
 }
 
 func findPackage(e ftypes.Package, s []ftypes.Package) *ftypes.Package {
-	for _, a := range s {
+	for i := range s {
+		a := &s[i] // do not range by value to avoid heap allocations
 		if a.Name == e.Name && a.Version == e.Version && a.Release == e.Release {
-			return &a
+			return a
 		}
 	}
 	return nil