fix(misconf): init frameworks before updating them (#7376)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
aquasecurity · Aug 23, 2024 · b65b32d · b65b32d
1 parent 9ef05fc
commit b65b32d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pkg/iac/rego/metadata.go b/pkg/iac/rego/metadata.go
@@ -54,6 +54,9 @@ func NewStaticMetadata(pkgPath string, inputOpt InputOptions) *StaticMetadata {
 }
 
 func (sm *StaticMetadata) Update(meta map[string]any) error {
+	if sm.Frameworks == nil {
+		sm.Frameworks = make(map[framework.Framework][]string)
+	}
 
 	upd := func(field *string, key string) {
 		if raw, ok := meta[key]; ok {

diff --git a/pkg/iac/rego/metadata_test.go b/pkg/iac/rego/metadata_test.go
@@ -97,6 +97,7 @@ func Test_UpdateStaticMetadata(t *testing.T) {
 			References:     []string{"r", "r1_n", "r2_n"},
 			CloudFormation: &scan.EngineMetadata{},
 			Terraform:      &scan.EngineMetadata{},
+			Frameworks:     make(map[framework.Framework][]string),
 		}
 
 		assert.Equal(t, expected, sm)
@@ -114,6 +115,7 @@ func Test_UpdateStaticMetadata(t *testing.T) {
 			References:     []string{"r", "r1_n", "r2_n"},
 			CloudFormation: &scan.EngineMetadata{},
 			Terraform:      &scan.EngineMetadata{},
+			Frameworks:     make(map[framework.Framework][]string),
 		}
 
 		assert.Equal(t, expected, sm)
@@ -131,10 +133,19 @@ func Test_UpdateStaticMetadata(t *testing.T) {
 			Deprecated:     true,
 			CloudFormation: &scan.EngineMetadata{},
 			Terraform:      &scan.EngineMetadata{},
+			Frameworks:     make(map[framework.Framework][]string),
 		}
 
 		assert.Equal(t, expected, sm)
 	})
+
+	t.Run("frameworks is not initialized", func(t *testing.T) {
+		sm := StaticMetadata{}
+		err := sm.Update(map[string]any{
+			"frameworks": map[string]any{"all": []any{"a", "b", "c"}},
+		})
+		require.NoError(t, err)
+	})
 }
 
 func Test_NewEngineMetadata(t *testing.T) {