Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flag): support globalstar to skip directories #4854

Merged
merged 1 commit into from
Jul 23, 2023
Merged

fix(flag): support globalstar to skip directories #4854

merged 1 commit into from
Jul 23, 2023

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Jul 21, 2023 •
edited
Loading

Description

Globstar support has been added for the --skip-files flag, but not for --skip-dirs.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin changed the title fix(flag): use globalstar to skip directories fix(flag): support globalstar to skip directories Jul 21, 2023
@nikpivkin nikpivkin marked this pull request as ready for review July 21, 2023 10:27
@nikpivkin nikpivkin requested a review from knqyf263 as a code owner July 21, 2023 10:27
@nikpivkin nikpivkin mentioned this pull request Jul 21, 2023
Closed
@knqyf263 knqyf263 added this pull request to the merge queue Jul 23, 2023
Merged via the queue into aquasecurity:main with commit a61531c Jul 23, 2023
13 checks passed
@nikpivkin nikpivkin deleted the nik-globstar-dir branch July 23, 2023 15:48
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@nikpivkin @AnaisUrlichs
fix(flag): use globalstar to skip directories (aquasecurity#4854)
4346f5d
@kstevensonnv kstevensonnv mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trivy doesn't skip directories when using doublestar in --skip-dirs flag
2 participants
@nikpivkin @knqyf263