Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin): respect --insecure #7022

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(plugin): respect --insecure #7022

merged 2 commits into from
Jun 26, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

--insecure is not respected for plugin subcommands now.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
fix: respect --insecure for plugins
0499c6b 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Jun 26, 2024
@knqyf263 knqyf263 changed the title fix: respect --insecure for plugins fix: respect --insecure for plugins Jun 26, 2024
@knqyf263 knqyf263 changed the title fix: respect --insecure for plugins fix(plugin): respect --insecure Jun 26, 2024
@knqyf263 knqyf263 marked this pull request as ready for review June 26, 2024 08:38
@knqyf263
Copy link
Collaborator Author

I hope the tests will pass 🤞 I want a review queue option that marks PR ready for review after all tests pass, similar to a merge queue.

DmitriyLewen
DmitriyLewen reviewed Jun 26, 2024
View reviewed changes
pkg/commands/app.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC we need to add insecure option for run flag.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added 7b1eda6

@knqyf263
fix: add insecure to "plugin run"
7b1eda6 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
DmitriyLewen
DmitriyLewen approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 enabled auto-merge June 26, 2024 10:21
@knqyf263 knqyf263 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into aquasecurity:main with commit 3d02a31 Jun 26, 2024
12 checks passed
@knqyf263 knqyf263 deleted the fix/plugin_index_insecure branch June 26, 2024 10:45
@aqua-bot aqua-bot mentioned this pull request Jun 26, 2024
Merged
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
@knqyf263 @skahn007gl
fix(plugin): respect --insecure (aquasecurity#7022)
2fa4ba3 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(plugin): respect --insecure
2 participants
@knqyf263 @DmitriyLewen