Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secret): move warning about file size after IsBinary check #7123

Conversation

DmitriyLewen
Copy link
Contributor

Description

Fix problem that we write warning every each binary file larger than 10MB.

Before:

➜ ./trivy fs --scanners secret ./trivy 
2024-07-09T12:19:09+06:00       INFO    Secret scanning is enabled
2024-07-09T12:19:09+06:00       INFO    If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-09T12:19:09+06:00       INFO    Please see also https://aquasecurity.github.io/trivy/dev/docs/scanner/secret#recommendation for faster secret detection
2024-07-09T12:19:09+06:00       WARN    [secret] The size of the scanned file is too large. It is recommended to use `--skip-files` for this file to avoid high memory consumption.     file_path="trivy" size (MB)=240

After:

➜  ./trivy fs --scanners secret ./trivy
2024-07-09T12:21:13+06:00       INFO    Secret scanning is enabled
2024-07-09T12:21:13+06:00       INFO    If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-09T12:21:13+06:00       INFO    Please see also https://aquasecurity.github.io/trivy/dev/docs/scanner/secret#recommendation for faster secret detection

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 9, 2024 07:08
@knqyf263 knqyf263 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into aquasecurity:main with commit 5a9f1a6 Jul 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants