Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): error on missing config file #7154

Merged
merged 5 commits into from
Jul 25, 2024
Merged

fix(cli): error on missing config file #7154

merged 5 commits into from
Jul 25, 2024

Commits on Jul 17, 2024

  1. fix: error out when explicitly config file cannot be found 

    The current behavior is to log a debug message and continue which
means that the scan that will happen will not match the expectation
of the user.

Now, if a user explicitly set the config file path, an error will be
raised otherwise, the original behavior will apply.
    @sgaist
    sgaist committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7e25efc View commit details
    Browse the repository at this point in the history

  2. refactor: log a warning when default configuration is not found 

    This will inform the user better when the default configuration file is not found.
    @sgaist
    sgaist committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cfebe6a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. refactor: put log back to debug when default configuration is not found

    @sgaist
    sgaist committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3d397f0 View commit details
    Browse the repository at this point in the history

  2. fix(app_test): simplify string to check for missing configuration error 

    Part of the message is OS dependent so remove it to ensure it passes
on all platforms.
    @sgaist
    sgaist committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    300d2d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'main' into error_on_missing_config_file

    @sgaist
    sgaist committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    aed9b7b View commit details
    Browse the repository at this point in the history