chore(deps): Bump trivy-checks #7417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
nikpivkin
reviewed
Aug 29, 2024
Comment on lines
-557
to
-561
| libs, err := rego.LoadEmbeddedLibraries() | ||
| require.NoError(t, err) | ||
| for name, library := range libs { | ||
| regoMap["/rules/"+name] = library.String() | ||
| } |
There was a problem hiding this comment.
OPA has a bug with converting a module to a string and back. https://github.com/open-policy-agent/opa
Especially there is no point in loading the libraries yourself, as Rego scanner can do it.
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
nikpivkin
force-pushed
the
bump-trivy-checks-v0.14.0
branch
from
40d3595
to
98d7175
Compare
nikpivkin
reviewed
Aug 29, 2024
| @@ -33,7 +33,7 @@ func Test_Scanning_Plan(t *testing.T) { | |||
| failedResults = append(failedResults, r) | |||
| } | |||
| } | |||
| assert.Len(t, results, 15) | |||
nikpivkin
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump trivy-checks
Related PRs: