Port e2e tests to node

[kernelwhisperer]

Todo:

• Fix CI

[kernelwhisperer]

The same issue we had with bash, doing subprocess.kill() would not stop a background process.

For example:

13388 ~ 'node: npm test'
  `- 9164 ~ 'node: ava'
    `- 9488 ~ 'node: execa'   <- this is what I get in the test, which does not want to die :(
      `- 11808 ~ 'node: aragon ipfs' 
        `- 24548 ~ 'ipfs' 

Even if we listen to the 'exit' event in the CLI:

  process.on('exit', (code, signal) => {
    console.log('parent said exit', code, signal)
    ipfsProc.kill()
    process.exit()
  })

Most likely child.pid returns a Group ID, and node cannot kill groups on windows: nodejs/node#3617

Solution: https://www.npmjs.com/package/ps-tree which returns the 2 children which we can kill. 🔪

[0xGabi]

Great solution 🎉

[kernelwhisperer]

There are some issues with nixt:

• for some reason the callback style .end() function did not play nice with ava (could have been because of me), had to extend it to support promises.
• does not support snapshots - I don't think there is a way to return the stdout so we cannot use our own assertions.
• does not support background tasks, which is why I created the startBackgroundProcess utility.
• does not play nice with windows, commands need to be appended with .cmd, see issue, they should use execa or cross-spawn.

I think we should simply use execa and ava assertions instead.

[0xGabi]

Seems a great tool anyway, but those are big downside in our case. Maybe when we test a bigger command like aragon run we will discover if only execa and ava is enough or we need at some point add other tooling

[kernelwhisperer]

Finally made Travis work!

First it was failing because of the lockfiles: github:ahultgren/async-eventemitter and github:frozeman/WebSocket-Node

Then with ENOENT even though the packages should have been linked by lerna bootstrap (I even tried --force-local): https://travis-ci.org/aragon/aragon-cli/builds/501944557#L579

Thirdly, because of OS specific text, see src/util.js#normalizeOutput.

Ended up using hacky solution: running npm link after installing 🤔

[kernelwhisperer]

This is created at the root folder when installing go-ipfs on windows 🤷‍♂️

[kernelwhisperer]

The build script is automatically ran after install because of npm prepare

[0xGabi]

Working great 🎉

[sohkai]

On npm link, I don't know what the particular issue is, but apparently lerna bootstrap is dying for lerna link so maybe that's could be something to look into.

[kernelwhisperer]

Then with ENOENT even though the packages should have been linked by lerna bootstrap (I even tried --force-local): travis-ci.org/aragon/aragon-cli/builds/501944557#L579

On npm link, I don't know what the particular issue is, but apparently lerna bootstrap is dying for lerna link so maybe that's could be something to look into.

Looks like it was an issue on my part actually 😅.
I described the issue here: https://github.com/aragon/aragon-cli/pull/439/files#diff-c3d8c26e209da78ecf8c501174996f65R18