Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Clean up exports and dependencies #601

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Chore: Clean up exports and dependencies #601

merged 2 commits into from
Jul 24, 2020

Conversation

facuspagnuolo
Copy link
Contributor

@facuspagnuolo facuspagnuolo commented Jul 23, 2020 •
edited by sohkai
Loading

Merge after #600.

Fixes #515.

@facuspagnuolo facuspagnuolo self-assigned this Jul 23, 2020
@auto-assign auto-assign bot requested a review from izqui July 23, 2020 16:03
@coveralls
Copy link

coveralls commented Jul 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 98.502% when pulling e14e9b7 on clean_up_exports into 914fed8 on next.

sohkai
sohkai approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍..................😍

..........😍..........

.😍..............😍.
....😍........😍...
........😍😍.......

package.json
"scripts": {
"compile": "truffle compile",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the compile script is still useful, but curious if you think it isn't!

@facuspagnuolo facuspagnuolo merged commit 8cee305 into next Jul 24, 2020
@facuspagnuolo facuspagnuolo deleted the clean_up_exports branch July 24, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

@izqui izqui Awaiting requested review from izqui

Assignees

@facuspagnuolo facuspagnuolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deploy scripts
3 participants
@facuspagnuolo @coveralls @sohkai