fix: instruct user to install Frame as their Ethereum provider in electron environments #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider in electron environments
sohkai
changed the title
sohkai
commented
Feb 15, 2019
| @@ -118,6 +119,9 @@ export function getUnknownBalance() { | |||
|
|
|||
| // Returns an identifier for the provider, if it can be detected | |||
| export function identifyProvider(provider) { | |||
| if (provider && isElectron()) { | |||
There was a problem hiding this comment.
Note that there's not a really good way to check for if we're connected to frame yet (could try checking against localhost:1234).
See #621 on detecting frame better.
AquiGorka
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614
Also fixes the detection of no injected Ethereum provider.