Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conversion warnings #39

Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix conversion warnings #39

merged 1 commit into from
Apr 20, 2020

Conversation

modkin
Copy link
Contributor

@modkin modkin commented Mar 23, 2020

since add_executable is used without sources the minimum required version has to be 3.11.
see: https://cmake.org/cmake/help/v3.11/release/3.11.html#commands

@modkin
Copy link
Contributor Author

modkin commented Mar 23, 2020

Just realized I did not work on the current master. I will rebase and fix. Sorry

@aras-p
Copy link
Owner

aras-p commented Apr 17, 2020

FYI #42 adjusted CMakeLists.txt to not require 3.11

@modkin
Copy link
Contributor Author

modkin commented Apr 17, 2020

Sorry I totally forgot about this PR.
Great then the minimum version can stay as it is.
I will revert it and have a look into the checks then.

@modkin modkin changed the title fix conversion warnings; adjust cmake_minimum_required fix conversion warnings Apr 17, 2020
@modkin
Copy link
Contributor Author

modkin commented Apr 20, 2020

This would be ready for merge

@aras-p aras-p merged commit 280e5c5 into aras-p:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modkin @aras-p