Support mulitple processes on same download dir #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… once, all use protoc-fetcher Currently this test fails on my machine
in an attempt to improve performance in concurrent usage test zip has far more downloads than zip-extract so assume it's a better solution
BaxHugh
force-pushed
the
fix/support-mulitple-processes-on-same-download-dir
branch
from
952d0f8 to
80da248
Compare
…processes to run at once
BaxHugh
force-pushed
the
fix/support-mulitple-processes-on-same-download-dir
branch
from
80da248 to
ac3c521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @jdahlq for this crate!
I have a cargo workspace where a few crates are all using protoc-fetcher in their build.rs script. Some of them depend on other crates too.
When I run cargo build on the workspace, or on a crate that has a dependency also using protoc-fetcher, protoc-fetcher runs in multiple instances at the same time on the same download directory (i.e. only one download directory for the cargo workspace)
I took a while to figure out what the issue was, but it's that there's multiple writes happening to the same dir at the same time.
I've added a test for this case and have implemented a lock file to solve the issue.
Other changes I implemented while figuring out the issue in this PR:
use
zipcrate instead ofzip-extractupdated dependencies
add additional context to failures with anyhow::Context, since I was seeing "Permissions Error" with no context, that made debugging difficult.