Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Release 09] Crash when new video gets loaded, while one is still opened #23

Closed
daed-alus opened this issue Jan 28, 2023 · 5 comments
Closed

[Feature Release 09] Crash when new video gets loaded, while one is still opened #23

daed-alus opened this issue Jan 28, 2023 · 5 comments
Labels
can't reproduce Couldn't reproduce, will not be fixed unless more details are given or I'm able to reproduce this.

Comments

@daed-alus
Copy link

Feature Release 09
if you load a new video "directly" (drag n drop & select file from open dialog) while one is still opened, the application crashes
if you first close the old video, new one gets loaded normally

happens with mkv files and avs scripts
@arch1t3cht
Copy link
Owner

Does this happen consistently for any kind of video? I'm asking since I can't reproduce that.
Also, what do you have set for the audio and video providers in Preferences > Advanced > Audio / Video ?

@daed-alus
Copy link
Author

daed-alus commented Jan 29, 2023 •
edited
Loading

yes happens everytime
both is set to ffmpeg

forgot to say, im on windows portable

@ipid
Copy link

ipid commented Feb 17, 2023

I can confirm this issue because I occasionally triggered this bug. I don't know how because it never happens again.

@arch1t3cht arch1t3cht added the can't reproduce Couldn't reproduce, will not be fixed unless more details are given or I'm able to reproduce this. label Apr 1, 2023
@daed-alus
Copy link
Author

still happens with FR 10

arch1t3cht added a commit that referenced this issue Oct 15, 2023
@arch1t3cht
Further fixes to audio/video provider selection
39fc834 
- Fix selection not aborting when the preferred provider returns null
- Fix the default video provider being "ffmpegsource" (lowercase)
  instead of "FFmpegSource", which would trip up provider selection
- More generally, make sure the preferred video provider actually exists
  and fall back to the default (FFmpegSource) if not.

Fixes #23 .
Fixes #61 .
Fixes #83 .
@arch1t3cht
Copy link
Owner

Probably fixed, see #83 (comment) for more information. Reopen if this still happens.

arch1t3cht added a commit that referenced this issue Oct 15, 2023
@arch1t3cht
Further fixes to audio/video provider selection
dd3016a 
- Fix selection not aborting when the preferred provider returns null
- Fix the default video provider being "ffmpegsource" (lowercase)
  instead of "FFmpegSource", which would trip up provider selection
- More generally, make sure the preferred video provider actually exists
  and fall back to the default (FFmpegSource) if not.

Fixes #23 .
Fixes #61 .
Fixes #83 .
0tkl pushed a commit to 0tkl/Aegisub that referenced this issue Oct 16, 2023
@arch1t3cht @0tkl
Further fixes to audio/video provider selection
4fde3a7 
- Fix selection not aborting when the preferred provider returns null
- Fix the default video provider being "ffmpegsource" (lowercase)
  instead of "FFmpegSource", which would trip up provider selection
- More generally, make sure the preferred video provider actually exists
  and fall back to the default (FFmpegSource) if not.

Fixes arch1t3cht#23 .
Fixes arch1t3cht#61 .
Fixes arch1t3cht#83 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
can't reproduce Couldn't reproduce, will not be fixed unless more details are given or I'm able to reproduce this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ipid @daed-alus @arch1t3cht