[bestsource] Add title/language in the track selection menu #173
+16
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moi15moi
force-pushed
the
Add-track-title
branch
from
7de5cec to
6ed57a0
Compare
bestsource (R9-RC1) now require: - libavcodec: >=61.19.0 - libavformat: >=61.7.0 - libavutil:>=59.39.0
moi15moi
force-pushed
the
Add-track-title
branch
from
6ed57a0 to
4a9e7d0
Compare
|
bestsource has a new version (R9-RC1) which include the new API to get the track metadata. For the moment, you can get the build here (since the workflow still haven't been triggered in this PR). PS: I'm still waiting for the R9 version to be available. |
The [commit](vapoursynth/bestsource@c25cf29) added a new API, so we can retrieve the track metadata.
This [commit](vapoursynth/bestsource@4f6ef06) removed the VariableFormat parameter in videosource.h This [commit](vapoursynth/bestsource@2817e14) removed the VariableFormat parameter in audiosource.h
This [commit](vapoursynth/bestsource@633d6e8#diff-fe0470628acf368c8971852850ca82394169b0fd8a64c78426663f21ee0ef2a2) added the ViewID parameter in videosource.h Let's set it to 0 since we don't support spatial videos.
moi15moi
force-pushed
the
Add-track-title
branch
from
4a9e7d0 to
a4a9cad
Compare
|
R9 is now available. Now, this PR use this new version instead of R9-RC1. I think the PR is finished. Let me know if there is any problem! For the moment, you can get the build here (since the workflow still haven't been triggered in this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR actually close #171, but only with the bestsource provider.
Before
Video track
Audio track
Now
Video track
Audio track
