Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate-limit login views #10323

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Rate-limit login views #10323

merged 3 commits into from
Dec 1, 2023

Conversation

jacobtylerwalls
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Add rate limiting to auth views. Expose RATE_LIMIT as a setting. See accepted possibilities, e.g. 12/5m, or a python callable.

aarongundel
aarongundel approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobtylerwalls
Copy link
Member Author

Thanks for taking a look!

@jacobtylerwalls jacobtylerwalls merged commit 886b62f into dev/6.2.x Dec 1, 2023
2 checks passed
@jacobtylerwalls jacobtylerwalls deleted the rate-limit-auth branch December 1, 2023 21:29
@jacobtylerwalls jacobtylerwalls mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongundel aarongundel aarongundel approved these changes

Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @aarongundel