Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade openpyxl, #10614 #10675

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Downgrade openpyxl, #10614 #10675

merged 1 commit into from
Mar 13, 2024

Conversation

njkim
Copy link
Collaborator

@njkim njkim commented Mar 12, 2024 •
edited
Loading

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Downgrade openpyxl for compatibility.
Fix the issue with excel importer and exporter not properly working, #10614

Arches would need to be updated to work with updated openpyxl library.
So, it would be great that the ticket (#10614) will remain open.

Issues Solved

#10614

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@njkim njkim requested a review from chiatt March 12, 2024 23:54
chiatt
chiatt approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chiatt chiatt merged commit 35c33dc into dev/7.6.x Mar 13, 2024
4 checks passed
@chiatt chiatt deleted the 10614_downgrade_openpyxl branch March 13, 2024 15:11
@chiatt chiatt linked an issue Mar 13, 2024 that may be closed by this pull request
openpyxl upgrade causes error in BDM template downloads #10614
Closed
rayondemiel added a commit to rayondemiel/arches that referenced this pull request Mar 29, 2024
@rayondemiel
Update archesproject#10675 - replace save_virtual_workbook deprecated…
630704e 
… to NamedTemporaryFile
chiatt pushed a commit that referenced this pull request Apr 13, 2024
@rayondemiel
Fixing bulk manager (#10726)
8719804 
* fix indentation create_tile_excel_workbook()

fixing iteration in  create_tile_excel_workbook() -> error i variable

* Fix multiple argument issue in post method etl_manager

* Update #10675 - replace save_virtual_workbook deprecated to NamedTemporaryFile

* Fix -- Windows compatibility NamedTemporaryFile #9180 #10322

* Upgrade openpyxl version 3.1.2

* Fixed - TypeError handling when return value is None

* Remove tmp file (windows issue) #9180

* Update release 7.6 notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openpyxl upgrade causes error in BDM template downloads
2 participants
@njkim @chiatt