Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discardLanguage filter #352

Closed
ruebot opened this issue Aug 21, 2019 · 0 comments · Fixed by #353
Closed

Add discardLanguage filter #352

ruebot opened this issue Aug 21, 2019 · 0 comments · Fixed by #353
Assignees
@ruebot
Labels
DataFrames enhancement rdd Scala

Comments

@ruebot
Copy link
Member

ruebot commented Aug 21, 2019

We have keep/discard pairs for pretty much everything in RecordLoader.

We don't have a discard one for keepLanguage. We might as well add it.
@ruebot ruebot self-assigned this Aug 21, 2019
ruebot added a commit that referenced this issue Aug 21, 2019
@ruebot
Add discardLanguage filter to RecordLoader.
3e70492 
- Clean up doc comments
- Add test
- Resolves #352
@ruebot ruebot mentioned this issue Aug 21, 2019
Merged
ianmilligan1 pushed a commit that referenced this issue Aug 23, 2019
@ruebot @ianmilligan1
Add discardLanguage filter to RecordLoader. (#353)
0284d33 
- Clean up doc comments
- Add test
- Resolves #352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
DataFrames enhancement rdd Scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add discardLanguage filter to RecordLoader. archivesunleashed/aut
1 participant
@ruebot