fix #199: mime-type was incorrectly parsed from content-type when cha…

[dportabella]

fix #199: mime-type was incorrectly parsed from content-type when charset param exists

---

GitHub issue(s):

If you are responding to an issue, please mention their numbers below.
#199

What does this Pull Request do?

Calling WarcRecordUtils.getWarcResponseMimeType with a header such as Content-Type: text/html;charset=ISO-8859-1 should return text/html. However it was returning text/html;charset=ISO-8859-1. Also, the function keepValidPages was not working properly because of this.

This pull request fixes this issue.

How should this be tested?

A unit test was added: WarcLoaderTest.testContentTypeWithCharset

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

• Does this change require documentation to be updated?
  No

• Does this change add any new dependencies?
  No

• Could this change or impact execution of existing code?
  No

Interested parties

Tag (@ mention) interested parties.

Thanks in advance for your help with the Archives Unleashed Toolkit!

[ruebot]

@dportabella thanks for the PR! Love seeing this 😃

Looks like you got hit by checkstyle: https://travis-ci.org/archivesunleashed/aut/jobs/370216592#L4855-L4856

[dportabella]

Line are limited to 80 characters? 😖
Ok, I fix this.
How do I test that it passes checkstyle? (I executed mvn package and it did succeed)
Then I create a new commit with --amend?
or I delete this pull-request and I create a new one?

[ruebot]

@dportabella oh, you can create a new commit and push, and it'll automatically update here. I'll squash things done on merge.

[codecov]

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files          32       32           
  Lines         636      636           
  Branches      124      124           
=======================================
  Hits          428      428           
  Misses        167      167           
  Partials       41       41

Impacted Files	Coverage Δ
...ava/io/archivesunleashed/data/WarcRecordUtils.java	61.53% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fab5b...f4e03a6. Read the comment docs.

[ruebot]

@lintool can I get one more set of eyes on this before I hit merge?

[lintool]

I think you might mean "compliant"?
How about - "Moreover, this simple regular expression is not compliant with the specification."

[lintool]

Minor typo, otherwise lgtm.

[ianmilligan1]

@dportabella Thanks for this pull request! I think if you incorporate or consider @lintool's comments above (you can just push the changes to the branch and the PR will be updated) we'll be able to merge this into AUT.

[dportabella]

done.

[greebie]

Thanks for being a contributor, @dportabella !

[dportabella]

welcome :)