Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issue templates #216

Merged
merged 2 commits into from
May 2, 2018
Merged

Create issue templates #216

merged 2 commits into from
May 2, 2018

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented May 2, 2018

No description provided.

@ruebot
Copy link
Member Author

ruebot commented May 2, 2018

Let me know if anything needs to be tweaked. If so, I'll update auk, and warclight.

@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          34       34           
  Lines         665      665           
  Branches      124      124           
=======================================
  Hits          440      440           
  Misses        184      184           
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505c47a...48a44cc. Read the comment docs.

@ruebot ruebot requested review from ianmilligan1 and SamFritz May 2, 2018 13:52
Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic. I just had a few minor suggestions which you can take or leave. 😄 Then I think it is ready to merge.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify "Desktop/Laptop" (don't laugh, I've seen this throw people off)

A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an e.g. to make clear that they should tweak these steps and not try to shoehorn their workflow into the ellipses

If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change example to
[e.g. MacOS 10.13.3]

@SamFritz
Copy link
Member

SamFritz commented May 2, 2018

Looks great @ruebot!

Just a quick question: what happens in the workflow if a user wants to request a feature (e.g. for AUK) but doesn't have GitHub account? I know we want to encourage everyone to fill out the template through Git, but just thinking about someone who may only be using AUK through the GUI.

(this may be a questions for down the line).

Copy link
Member

@SamFritz SamFritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ruebot! Examples given are very helpful!

@ruebot
Copy link
Member Author

ruebot commented May 2, 2018

@SamFritz Slack or email? Then we could create an issue. Good question though.

@ianmilligan1
Copy link
Member

Good point! If they click "new issue" w/o an account they'll get this.

screen shot 2018-05-02 at 3 16 54 pm

So maybe in places on the platform, etc. where we provide a link to "open an issue," we could also have an invitation to join our Slack group or e-mail us?

If that sounds good, we can merge this and keep this in mind for places where we invite people to open issues?

@SamFritz
Copy link
Member

SamFritz commented May 2, 2018

I think email might be easier to manage (in terms of documenting specific cases/instances of features/bugs, Slack blends all conversations together). But I also realize that more and more people are on Slack. :)

Merge sounds good!

@ianmilligan1 ianmilligan1 merged commit ef6ea36 into master May 2, 2018
@ianmilligan1 ianmilligan1 deleted the issue-templates branch May 2, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants