Remove duplicate call of keepValidPages #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruebot
reviewed
May 15, 2018
| @@ -105,7 +105,7 @@ package object archivesunleashed { | |||
| } | |||
|
|
|||
| def extractHyperlinksDF(): DataFrame = { | |||
| val records = rdd.keepValidPages() | |||
| val records = rdd | |||
There was a problem hiding this comment.
@lintool do you have a preference of where it is removed? I'm good with how it is.
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
======================================
Coverage 61.7% 61.7%
======================================
Files 34 34
Lines 679 679
Branches 124 124
======================================
Hits 419 419
Misses 219 219
Partials 41 41
Continue to review full report at Codecov.
|
|
codecov is really wacked sometimes.... why red if there's a 0% diff in coverage? |
lintool
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
As title
How should this be tested?
mvn clean installInterested parties