Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated ExtractGraph app #293

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Remove Deprecated ExtractGraph app #293

merged 3 commits into from
Nov 28, 2018

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Nov 28, 2018

GitHub issue(s):

#291

What does this Pull Request do?

Removes ExtractGraph which was previously deprecated. ExtractGraphX is the current replacement.

How should this be tested?

Travis / codecov should suffice.

Interested parties

@ianmilligan1 @ruebot

Thanks in advance for your help with the Archives Unleashed Toolkit!

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #293 into master will increase coverage by 2.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   73.39%   75.76%   +2.36%     
==========================================
  Files          42       41       -1     
  Lines        1184     1147      -37     
  Branches      210      202       -8     
==========================================
  Hits          869      869              
+ Misses        244      209      -35     
+ Partials       71       69       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7731b6d...4c74d7c. Read the comment docs.

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds nicely locally too.

I don't think we've had any real use of the ExtractGraph functionality, and there's the newer ExtractGraphX. Given all this, I think this is a good removal for 0.18.

@ianmilligan1
Copy link
Member

And just to link this to the PR where the deprecated notice was included, so this shouldn't be a surprise to anybody: https://github.com/archivesunleashed/aut/pull/245/files

@ruebot ruebot merged commit ab32df4 into master Nov 28, 2018
@ruebot ruebot deleted the issue-291 branch November 28, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants