Update keepValidPages to include a filter on 200 OK. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add status code filter to keepValidPages - Add MimeTypeTika to valid pages DF - Update tests since we filter more and better now 😄 - Resolves #359
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 75.93% 75.93% -0.01%
==========================================
Files 39 39
Lines 1388 1392 +4
Branches 266 267 +1
==========================================
+ Hits 1054 1057 +3
Misses 218 218
- Partials 116 117 +1 |
ianmilligan1
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Built and tested locally - all checks out. For fun, I ran a diff on the file using this branch vs. the 0.18.0 release. Here are the things that no longer appear in the plain text output.
If you keep scrolling it's this stuff over and over again, so I'd say this is a major enhancement. Great stuff, @ruebot !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #359
What does this Pull Request do?
How should this be tested?
Additional Notes: