Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.0.0 + Hadoop 3.2 + Java 11 support. #385

Closed
wants to merge 50 commits into from
Closed

Spark 3.0.0 + Hadoop 3.2 + Java 11 support. #385

wants to merge 50 commits into from

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Nov 26, 2019

GitHub issue(s):

What does this Pull Request do?

This PR is #375 + Hadoop 3.2 support.

How should this be tested?

Same as #375 + It should be tested with spark-3.0.0-preview-bin-hadoop3.2.

Additional Notes:

Same as #375

ruebot and others added 30 commits July 30, 2019 23:48
- Add copyMerge implementation in Scala (copyMerge is deprecated in
Hadoop 3)
- Update NERCombinedJson to use new copyMerge implementation
- 40 days and nights wandering the desert of pom.xml
- Some hacks to get a sucessful build
- Definitely need to loop back and clean-up a whole lot!
- Addresses #356
…talled 🤦, and a bunch more pom cleanup.
@ruebot
Copy link
Member Author

ruebot commented Apr 11, 2020

I believe we're going to continue to fail here until this is resolved. If that is resolved, it should also help out with our other hacks around making Tika work.

import java.io.IOException

/** Reimplementation of FileUtil.copyMerge . */
object CopyMerge {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lintool we're adding this, since copyMerge was deprecated and removed from Hadoop 3. Do we need to actually implement it again, or should we just use coalesce like we do here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall this being my code... but I think that's fine.

@ruebot ruebot mentioned this pull request May 27, 2020
@ruebot
Copy link
Member Author

ruebot commented Jun 29, 2020

Going to close this, and re-open it against main so we can remove master #490.

@ruebot ruebot closed this Jun 29, 2020
@ruebot ruebot mentioned this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants