Clean up test descriptions, addresses #372. #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename typo filename - Remove potentially unnecessary tests
ruebot
commented
Jan 21, 2020
ianmilligan1
requested changes
Jan 21, 2020
src/test/scala/io/archivesunleashed/app/WriteGraphXMLTest.scala
Outdated
Show resolved
Hide resolved
ianmilligan1
approved these changes
Jan 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 41 41
Lines 1570 1570
Branches 292 292
=======================================
Hits 1224 1224
Misses 218 218
Partials 128 128 |
|
Ok, I'll put those back in. I stand corrected. |
SamFritz
approved these changes
Jan 21, 2020
| @@ -43,21 +43,21 @@ class RecordRDDTest extends FunSuite with BeforeAndAfter { | |||
| sc = new SparkContext(conf) | |||
| } | |||
|
|
|||
| test("no valid pages") { | |||
| test("Expect no valid pages") { | |||
There was a problem hiding this comment.
should this also include RDD at the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #372
What does this Pull Request do?
How should this be tested?