Add ExtractPopularImages, WriteGEXF, and WriteGraphML to Python. #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Partially addresses #409 - Clean up formatting in app.py - Cleanup doc comments on the Scala side - TODO: Extract Entities
ruebot
commented
May 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 49 49
Lines 1442 1442
Branches 279 279
=======================================
Hits 1094 1094
Misses 218 218
Partials 130 130 |
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
May 26, 2020
|
Here's the documentation update PR for when the time comes. |
|
Last item here is Extract Entities. We only have an RDD implementation of that. I'd argue that NER is something down the chain folks can do with the derivatives, and we don't need to implement it in the Scala DataFrame or Python side. ...which means, we could go as far as completely removing all the NER functionality. Though, not 100% wedded to that idea. |
|
Once we merge, I'm move those two notebooks over to the notebooks repo. |
ianmilligan1
approved these changes
May 27, 2020
ruebot
added a commit
to archivesunleashed/notebooks
that referenced
this pull request
May 27, 2020
Closed
ianmilligan1
pushed a commit
to archivesunleashed/aut-docs
that referenced
this pull request
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #409
What does this Pull Request do?
Add ExtractPopularImages, WriteGEXF, and WriteGraphML to Python.
How should this be tested?
[nruest@bomba:/tmp]$ wc -l scala-example.gexf ~/Projects/au/sample-data/notebook-testing/test.gexf 29186 scala-example.gexf 29186 /home/nruest/Projects/au/sample-data/notebook-testing/test.gexf 58372 total[nruest@bomba:/tmp]$ wc -l scala-example.graphml ~/Projects/au/sample-data/notebook-testing/test.graphml 33911 scala-example.graphml 33911 /home/nruest/Projects/au/sample-data/notebook-testing/test.graphml 67822 total