Move Python UDF methods out of their own class. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolve #467 - README button colour tweak for UserDocs
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 44 44
Lines 1297 1297
Branches 250 250
=======================================
Hits 1088 1088
Misses 80 80
Partials 129 129 |
lintool
reviewed
May 29, 2020
| @@ -1,5 +1,39 @@ | |||
| from aut.app import Extract_Popular_Images, Write_Gexf, Write_Graphml | |||
| from aut.common import WebArchive | |||
| from aut.udfs import Udf | |||
| from aut.udfs import ( | |||
| compute_image_size, | |||
|
|
||
| __all__ = ["Extract_Popular_Images", "Udf", "WebArchive", "Write_Gexf", "Write_Graphml"] | ||
| __all__ = [ | ||
| "Extract_Popular_Images", |
There was a problem hiding this comment.
Apologies in advance if this has been hashed out already, but have we agreed on a naming convention for these? Naming seems inconsistent at present...
ianmilligan1
approved these changes
May 29, 2020
There was a problem hiding this comment.
Ran through the two provided notebooks with CPP sample data - thanks for those @ruebot. All works perfectly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #467
What does this Pull Request do?
Move Python UDF methods out of their own class.
How should this be tested?