Fix relative links extraction #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #504 +/- ##
============================================
- Coverage 88.85% 88.83% -0.03%
Complexity 57 57
============================================
Files 43 43
Lines 1014 1012 -2
Branches 86 85 -1
============================================
- Hits 901 899 -2
Misses 74 74
Partials 39 39 |
ruebot
requested changes
Oct 9, 2020
There was a problem hiding this comment.
Thanks for documenting the issue, and submitting a fix @yxzhu16. This is great!
I have a PR against your PR which fixes the test you were having issues with. Once you merge that, this PR should automatically get updated, and we should be good to go.
| @@ -83,14 +83,6 @@ class ArcTest extends FunSuite with BeforeAndAfter { | |||
| assert(discardMatches.count == 284L) | |||
| } | |||
|
|
|||
| test("Count links RDD") { | |||
There was a problem hiding this comment.
Need a better solution here than just deleting the test.
- Remove unnecessary test results comment
Fix "Count links RDD" test.
ruebot
added a commit
that referenced
this pull request
Jan 18, 2021
Set baseUri to be `src` instead of `base` when extracting links, and deleted `base` parameter.
The issue occurred because relative links cannot be extracted by ` link.attr("abs:href")` when baseUri is not set.
As I look through the code, param `base` is never provided anywhere when `ExtractLinks` is called, so default value `""` is always used, and baseUri is never set. However, `baseUri` is required to be able to extract relative links.
* resolves #501
* update tests
* remove unnecessary test results comment
Co-authored-by: Kai Zhong <kaizhchn@hotmail.com>
Co-authored-by: nruest <ruestn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #501
What does this Pull Request do?
srcinstead ofbasewhen extracting links, and deletedbaseparameterThe issue occurred because relative links cannot be extracted by
link.attr("abs:href")when baseUri is not set.As I look through the code, param
baseis never provided anywhere whenExtractLinksis called, so default value "" is always used, and baseUri is never set. However, baseUri is required to be able to extract relative links.Instead of adapting the Python UDF to include the base parameter, I think it makes sense to set the baseUri to be
src. Similar asaut/src/main/scala/io/archivesunleashed/matchbox/ExtractImageLinks.scala
Line 42 in 00e8166
I tested on Wayback Machine bbc pidgin pages and it works.
One concern is that after modification the number of relative links is really really large compared to before, eg. in one of the test cases the number of links extracted 600 -> 30k. And in ArcTest "Count links RDD" I encountered
java.lang.StackOverflowErrorbecause of the large number of links.How should this be tested?