Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add authentication support for github client #10

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

kayano
Copy link
Contributor

@kayano kayano commented Sep 11, 2023

GitHub imposes a rate limit on all API clients. Unauthenticated clients are limited to 60 requests per hour, while authenticated clients can make up to 5,000 requests per hour. 60 requests per hour is easy to reach if the exporter is working on eg. kubernetes cluster next to other apps doing unauthenticated requests to GitHub.

Copy link
Contributor

@shahbazn shahbazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kayano kayano merged commit 825fea4 into main Sep 12, 2023
3 checks passed
@kayano kayano deleted the tn/github-token branch September 12, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants