Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ac.rkt: handle trash-whitespace errors – fixes #60 + #199 #228

Merged

Conversation

montyanderson
Copy link
Contributor

Firstly, thanks to everyone maintaining this fork of Arc – I've been using it to run a music aggregator and it's awesome.

However, I noticed that even a single request may saturate the CPU for multiple seconds, while filling the console with the following errors.

char-whitespace?: contract violation
   expected: char?
   given: #<eof>
   context...:
    /opt/textural/ac.rkt:1448:0: trash-whitespace
    /opt/textural/ac.rkt:1463:4

Refactoring the trash-whitespace function to handle the contract errors killed both birds with one stone!

Copy link
Member

@akkartik akkartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Just one minor comment if you could address it before merging.

ac.rkt Outdated Show resolved Hide resolved
@akkartik akkartik merged commit 50c8716 into arclanguage:master May 20, 2024
0 of 9 checks passed
@akkartik
Copy link
Member

Thank you!

@montyanderson montyanderson deleted the handle-trash-whitespace-errors branch May 20, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants