#46 Theme Settings: Custom Comment Contrast #47
Conversation
arcticicestudio
added
type-feature
context-config
status-requires-review
and removed
status-requires-review
labels
Use "yarn" instead of "npm" with globally installed packages. Also changed the "language" of attribute for Travis CI to "node_js" and specified versions.
Using yarn results in an endless loop of "Removing .yarn-integrity" errors.
|
Alright, I'll have to take care of the build errors at another time. Everything works fine on my local system (Arch Linux), but the builds on Travis Linux are failing with a JavaScript syntax error which can only be due to the Babel ES6 code (lambda function expression). |
|
+1. This works great. Accessibility percentage adjustments seem like a nice way to expose this. This worked well for me on my machine. Thanks! |
|
And FYI - I tested on my iMac and MacBook Pro both running latest Sierra and latest stable Atom. |
Restore the $PATH before running the Atom CI script to prevent conflicts with the bundled node version.
|
I finally fixed all Travis CI builds in all environments. The Anyway, I'll merge this PR into |
arcticicestudio
deleted the
feature/ghi-#46-adjustments-for-color-blindness
branch
> Description Added a accessibility theme customization to allow users to set the brightness of comments with percentage adjustments from 0% - 20% where 0 is the default nord3 comment color. When a invalid value is passed (< 0 || > 20 || nil) the default nord3 color is used. The customization is available through the nord-comment-brightness variable. This is a optional customization to provide a way for users to adjust the color to fit their needs: It is a port of the reference implementation from the Nord Atom UI project. The values are calculated using the LESSCSS lighten function to ensure full interoperability with other port projects that providing this theme feature. > Usage Example to increase the comment color brightness by 15%: (setq nord-comment-brightness 15) References: nordtheme/atom-syntax#47 http://lesscss.org/functions/#color-operations-lighten GH-43
> Description Added a accessibility theme customization to allow users to set the brightness of comments with percentage adjustments from 0% - 20% where 0 is the default nord3 comment color. When a invalid value is passed (< 0 || > 20 || nil) the default nord3 color is used. The customization is available through the nord-comment-brightness variable. This is a optional customization to provide a way for users to adjust the color to fit their needs: It is a port of the reference implementation from the Nord Atom UI project. The values are calculated using the LESSCSS lighten function to ensure full interoperability with other port projects that providing this theme feature. > Usage Example to increase the comment color brightness by 15%: (setq nord-comment-brightness 15) References: nordtheme/atom-syntax#47 http://lesscss.org/functions/#color-operations-lighten GH-43
> Description Added a accessibility theme customization to allow users to set the brightness of comments with percentage adjustments from 0% - 20% where 0 is the default nord3 comment color. When a invalid value is passed (< 0 || > 20 || nil) the default nord3 color is used. The customization is available through the nord-comment-brightness variable. This is a optional customization to provide a way for users to adjust the color to fit their needs: It is a port of the reference implementation from the Nord Atom UI project. The values are calculated using the LESSCSS lighten function to ensure full interoperability with other port projects that providing this theme feature. > Usage Example to increase the comment color brightness by 15%: (setq nord-comment-brightness 15) References: nordtheme/atom-syntax#47 http://lesscss.org/functions/#color-operations-lighten GH-43
This PR implements theme settings and various improvements to the build- and development workflow.
The initial implementation provides a setting to increase the contrast for comments by percentage.
The default value is
0which uses the default Nord color assignment while the maximum value is20.Example with an increased comment contrast value of
15(%):Unfortunately Atom does currently not support modifications of LESSCSS theme variables through configurations so a workaround has been implemented which stores LESSCSS variables in the index-imported
styles/theme-settings-store.lessfile to override the default LESSCSS variables defined in thestyles/syntax-variables.lessfile.Please see atom/atom PR #4153 and atom/atom #5735 for more information about the current limitations.