Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active and inactive modelines are hard to distinguish, as well as region highlight. #32

Closed
localredhead opened this issue Apr 25, 2017 · 3 comments
Closed

Active and inactive modelines are hard to distinguish, as well as region highlight. #32

localredhead opened this issue Apr 25, 2017 · 3 comments
Labels
context-configuration type-proposal
Milestone
0.4.0

Comments

@localredhead
Copy link

I have to squint on these two items., otherwise this is a perfect theme.

  1. I can barely tell what is selected in the region
  2. It is hard for me to distinguish between modelines.

Is this the right amount of contrast for the theme?
screen shot 2017-04-25 at 3 29 46 pm
@arcticicestudio
Copy link
Contributor

It is not easy to implement this when the theme engine is limited to pure HEX values. In other port projects it is possible to improve this by using transparency or advanced theming features like CSS.
Maybe I'll implement a theme setting which allows to percentage increase the comment color like the one in the Nord Atom UI.

@arcticicestudio arcticicestudio mentioned this issue May 6, 2017
Closed
@localredhead
Copy link
Author

For what its worth, I think a simple solution would be to invert the color on the inactive modeline, and use the current inactive color for a boxed edge and text. IMO that would solve it nicely.

I did have a version like this that I can try and submit as a PR somewhere... I did tinker a bit with it.

@arcticicestudio arcticicestudio mentioned this issue Sep 30, 2017
Closed
This was referenced Oct 1, 2017
Merged
Closed
arcticicestudio added a commit that referenced this issue Oct 1, 2017
@arcticicestudio
Implement uniform mode lines customization
6b80171 
> Description

Added a theme customization to allow users to enable uniform activate-
and inactive mode lines using "nord3" as background.

The default is left to "nord1" as background color.

The customization is available through the "nord-uniform-mode-lines"
variable of type "boolean".

> Usage

  (setq nord-uniform-mode-lines t)

Related to #32

GH-47
@arcticicestudio arcticicestudio mentioned this issue Oct 1, 2017
Merged
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 1, 2017 •
edited
Loading

@localredhead I've implemented two theme customizations

Feel free to check out the PRs and post some feedback.

@arcticicestudio arcticicestudio added this to the 0.4.0 milestone Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-configuration type-proposal
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@localredhead @arcticicestudio