-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Lines(this string) extensions method #52
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dce0780
Add .vscode folder to .gitignore
snowfrogdev 37a23ac
Implement a Lines(this string) extension method
snowfrogdev 49b2837
Add benchmarking project
snowfrogdev dc0158e
Optimize Lines(this string) with benchmarking
snowfrogdev 94638ad
Merge branch 'main' into lines
snowfrogdev 4012a72
Reorganize Benchmarks to follow project structure
snowfrogdev 8673f62
Rename static benchmark extensions
snowfrogdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -350,4 +350,4 @@ MigrationBackup/ | |
| .ionide/ | ||
|
|
||
| # Visual Studio Code configuration files | ||
| .vscode | ||
| .vscode | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
benchmarks/Ardalis.Extensions.Benchmarks/Ardalis.Extensions.Benchmarks.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <OutputType>Exe</OutputType> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <PlatformTarget>AnyCPU</PlatformTarget> | ||
| <DebugType>pdbonly</DebugType> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <Optimize>true</Optimize> | ||
| <Configuration>Release</Configuration> | ||
| <IsPackable>false</IsPackable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.12.1" /> | ||
| <PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.12.1"/> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Ardalis.Extensions\Ardalis.Extensions.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="bible.txt"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| using BenchmarkDotNet.Running; | ||
| using Ardalis.Extensions.Benchmarks.StringManipulation; | ||
|
|
||
| namespace Ardalis.Extensions.Benchmarks; | ||
|
|
||
| public class Program | ||
| { | ||
| public static void Main(string[] args) | ||
| { | ||
| var summary = BenchmarkRunner.Run<LinesBenchmarks>(); | ||
| } | ||
| } | ||
87 changes: 87 additions & 0 deletions
87
benchmarks/Ardalis.Extensions.Benchmarks/StringManipulation/LinesBenchmarks.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| using System.IO; | ||
| using BenchmarkDotNet.Attributes; | ||
| using Ardalis.Extensions.StringManipulation; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System; | ||
|
|
||
| namespace Ardalis.Extensions.Benchmarks.StringManipulation; | ||
|
|
||
| [MemoryDiagnoser] | ||
| public class LinesBenchmarks | ||
| { | ||
| private string Bible { get; set; } | ||
|
|
||
| [Params(1, 5, 10, 15)] | ||
| public int N { get; set; } | ||
| public LinesBenchmarks() | ||
| { | ||
| Bible = File.ReadAllText("bible.txt"); | ||
| } | ||
|
|
||
| [Benchmark(Baseline = true)] | ||
| public string[] LinesSplit() | ||
| { | ||
| return Bible.LinesSplit().Where((line, index) => index % N == 0).ToArray(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public string[] LinesSubstring() | ||
| { | ||
| return Bible.LinesSub().Where((line, index) => index % N == 0).ToArray(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public string[] LinesMemory() | ||
| { | ||
| return Bible.Lines().Where((line, index) => index % N == 0).Select(line => line.ToString()).ToArray(); | ||
| } | ||
| } | ||
|
|
||
| static class LinesBenchmarksExtensions | ||
| { | ||
| public static IEnumerable<string> LinesSplit(this string text) | ||
| { | ||
|
|
||
| var lines = text.Split(new[] { "\r\n", "\n" }, StringSplitOptions.None); | ||
|
|
||
| if (lines.Last() == "") return lines.Take(lines.Length - 1).ToArray(); | ||
|
|
||
| return lines; | ||
| } | ||
|
|
||
| public static IEnumerable<string> LinesSub(this string text) | ||
| { | ||
| var lineStartIndex = 0; | ||
| var currentIndex = 0; | ||
|
|
||
| while (currentIndex < text.Length) | ||
| { | ||
| if (text[currentIndex] == '\n') | ||
| { | ||
| yield return text.Substring(lineStartIndex, currentIndex - lineStartIndex); | ||
| lineStartIndex = currentIndex + 1; | ||
| currentIndex++; | ||
| continue; | ||
| } | ||
|
|
||
| if (text[currentIndex] == '\r') | ||
| { | ||
| if (currentIndex + 1 < text.Length && text[currentIndex + 1] == '\n') | ||
| { | ||
| yield return text.Substring(lineStartIndex, currentIndex - lineStartIndex); | ||
| lineStartIndex = currentIndex + 2; | ||
| currentIndex += 2; | ||
| continue; | ||
| } | ||
| } | ||
|
|
||
| if (currentIndex == text.Length - 1) | ||
| { | ||
| yield return text.Substring(lineStartIndex); | ||
| } | ||
|
|
||
| currentIndex++; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider ensuring benchmark methods return identical results