-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs builder extensions #162 #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - having code in the docs is good so folks don't need to hunt down the sample separately. You can link to the sample as needed if it's something where seeing it in context of a whole app will add clarity.
Co-authored-by: Steve Smith <steve@kentsmiths.com>
877eaa4
to
f11fe7c
Compare
You're doing great work here @vittorelli. |
I've updated the docs so it answers to the "Why". I didn't add it as a sample in the source because I felt it would somewhat conflict with the existing |
@fiseni Thanks :-) |
Awesome, thanks! |
Work in progress. Does this look okay?
Or should the docs contain less code and move that into the sample projects in stead?