-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for AsAsyncEnumerable #316
Conversation
@fiseni any concerns? |
I've been hesitant to add the |
Btw, I have nothing against this feature being merged. But, if someone complains, we should forward them here :) |
If I update the Ardalis.Specification to version 7.0.0 form version 6.1.0, I am getting Method 'AsAsyncEnumerable' in type '....EfRepository`1' from assembly 'Infrastructure, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.'. Why it is asking for implementation even though AsAsyncEnumerable is a virtual method |
Hi @nkz-soft, I assume you updated only the |
I tagged @nkz-soft by mistake. The message was intended to you @SrushtiPasari94. I saw you were working on EShop project. I commented in your PR there too. |
@fiseni Updates Ardalis.Specification.EntityFrameworkCore packages as well. Its working as expected. |
Hello @ardalis!
I use AsyncEnumerable in my project, and it would be nice to have it supported in this library.