Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for AsAsyncEnumerable #316

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

nkz-soft
Copy link
Contributor

Hello @ardalis!
I use AsyncEnumerable in my project, and it would be nice to have it supported in this library.

@ardalis
Copy link
Owner

ardalis commented Mar 21, 2023

@fiseni any concerns?

@fiseni
Copy link
Collaborator

fiseni commented Mar 21, 2023

I've been hesitant to add the AsAsyncEnumerable. The specifications may contain PostProcessingAction, and that won't work in this case, since you need the data in memory. I don't know if anyone is using that feature, but if anyone does, then they might get inconsistent behavior.

@fiseni
Copy link
Collaborator

fiseni commented Mar 21, 2023

Btw, I have nothing against this feature being merged. But, if someone complains, we should forward them here :)

@SrushtiPasari94
Copy link

SrushtiPasari94 commented Sep 8, 2023

If I update the Ardalis.Specification to version 7.0.0 form version 6.1.0, I am getting Method 'AsAsyncEnumerable' in type '....EfRepository`1' from assembly 'Infrastructure, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.'. Why it is asking for implementation even though AsAsyncEnumerable is a virtual method

@fiseni
Copy link
Collaborator

fiseni commented Sep 8, 2023

Hi @nkz-soft,

I assume you updated only the Ardalis.Specification package. You should update also the Ardalis.Specification.EntityFrameworkCore package. The IRepository interface has additional method, and the implementations are in the plugin package.

@SrushtiPasari94
Copy link

@nkz-soft / @fiseni Any updates on this?

@fiseni
Copy link
Collaborator

fiseni commented Sep 11, 2023

I tagged @nkz-soft by mistake. The message was intended to you @SrushtiPasari94.
You have to update the version for the plugin package.

I saw you were working on EShop project. I commented in your PR there too.

@SrushtiPasari94
Copy link

@fiseni Updates Ardalis.Specification.EntityFrameworkCore packages as well. Its working as expected.
Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants