Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support and infra for Node 4, 6, and 8. #63

Merged
merged 6 commits into from
Jan 30, 2018

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Jan 29, 2018

utilizing CircleCI's workflows feature, we can make sure that we can safely establish the engines field here.

i had explored compiling this code using babel's new TypeScript preset and using babel-preset-env to ensure we were transpiling everything we needed, but i hit issues both with making sure sourcemaps were covering the original TypeScript source code as well as the fact that our use of instance methods like Array.prototype.includes couldn't safely be polyfilled without polluting the global scope. do the simple thing here and just use lodash and hope the test harness catches any further regressions.

i dont have access to the release flow, so whoever is reviewing this should ensure that my semantic-release changes are okay. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants