Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1045 tables config #1046

Closed
wants to merge 4 commits into from
Closed

1045 tables config #1046

wants to merge 4 commits into from

Conversation

jrevault
Copy link

@jrevault jrevault commented Oct 6, 2020

Issue #1045

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 51a3d70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jrevault jrevault marked this pull request as draft October 6, 2020 14:11
@jrevault
Copy link
Author

jrevault commented Oct 6, 2020 •
edited
Loading

Steps for tests :

  • yarn build (in graph-ql root)
  • yarn start (in examples/mysql-employees)
  • open graphiql and tests queries

does not work => still old behavior.
Examples does not use the local graphql-mesh build, to check I added a 'if (false)' instead of 'if (requestedTables.length === 0 || requestedTables.indexOf(tableName) !== -1 )'

=> still going inside if 😞

@ardatan Any config has to be done to use local build ?
Could it be linked with the canary release fail : Error: Input required and not supplied: bot-token ?

@ardatan ardatan force-pushed the master branch 2 times, most recently from 913cca1 to ed6b0f5 Compare January 14, 2021 08:56
@ardatan
Copy link
Owner

ardatan commented Feb 9, 2021

Sorry for late response! Thank you for the PR @jrevault !
You can ignore canary release error :) Do you have Windows?

@ardatan ardatan force-pushed the master branch 2 times, most recently from 01600cb to 5ae2997 Compare February 11, 2021 22:49
@ardatan ardatan force-pushed the master branch 2 times, most recently from 5b4f070 to f13e4e6 Compare February 25, 2021 23:06
@ardatan ardatan force-pushed the master branch 2 times, most recently from ba50211 to 28f80c0 Compare May 1, 2021 12:37
@ardatan ardatan force-pushed the master branch 9 times, most recently from 99c88eb to 372e23b Compare June 1, 2021 18:00
@ardatan ardatan force-pushed the master branch 7 times, most recently from 4f40848 to 0a80d9e Compare June 8, 2021 16:03
@ardatan
Copy link
Owner

ardatan commented Jun 17, 2021

Thank you for the PR!
I'm moving those changes into #1045

@ardatan ardatan closed this Jun 17, 2021
@ardatan ardatan mentioned this pull request Jun 17, 2021
Merged
@jrevault jrevault deleted the 1045-tables-config branch August 25, 2021 06:57
klippx pushed a commit to klippx/graphql-mesh that referenced this pull request Oct 9, 2024
@kamilkisiela
onRateLimitError and {{id}} in rate-limiter (ardatan#1046)
b343f4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrevault @ardatan