fix/feat(serve): WebSockets for GW/Client comm #7766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build artifacts of |
|
The build artifacts of |
Apollo Federation Subgraph Compatibility Results
Learn more: |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/gateway |
1.3.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/hmac-upstream-signature |
1.2.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-jwt-auth |
1.2.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-opentelemetry |
1.3.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-operation-headers |
1.2.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
1.2.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/serve-cli |
1.3.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/serve-runtime |
1.2.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-http-callback |
0.5.0-alpha-20241017125351-19cd1c2d9a00f9217e1b38b0aa023f2e54a731d6 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://51789e9a.graphql-mesh.pages.dev |
|
The build artifacts of |
|
The build artifacts of |
|
Published |
|
Published |
enisdenjo
requested changes
Oct 14, 2024
packages/serve-cli/src/server.ts
Outdated
Comment on lines
146
to
152
| const { WebSocketServer } = await import('ws'); | ||
| const wsServer = new WebSocketServer({ | ||
| path: gwRuntime.graphqlEndpoint, | ||
| server, | ||
| }); | ||
| const graphqlWSOptions = getGraphQLWSOptions(gwRuntime); | ||
| const { useServer } = await import('graphql-ws/lib/use/ws'); |
There was a problem hiding this comment.
Why dynamic imports? Dynamic imports make it hard for bundlers.
ardatan
force-pushed
the
ws-support-gww
branch
from
e8b0fd0 to
185ed5b
Compare
ardatan
added a commit
that referenced
this pull request
Nov 20, 2024
* fix/feat(serve): WebSockets for GW/Client comm * chore(dependencies): updated changesets for modified dependencies * Fix unit tests * Fix e2e * Disable v18 for WS * Avoid dynamic imports * Add an option to enable/disable WebSockets --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose WebSockets server for the gateway and the client communication
Previously it wasn't possible to communicate with the gateway via WebSockets, now this implements it, updates the tests to make sure the gateway is accessible through WebSockets
node:httpserver in serve-clionRequestis not invoked when using WebSockets with uWS, therefore we cannot assign a schema to a request inuseSchemaYoga plugin - do something else(Now setting the schema in onSubscribe hook of graphql-ws)
Closes #7208