-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defer stream support within stitching #1941
base: master
Are you sure you want to change the base?
Commits on May 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5b7320e - Browse repository at this point
Copy the full SHA 5b7320eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6362145 - Browse repository at this point
Copy the full SHA 6362145View commit details -
update delegate to support defer/stream
- delegateToSchema stores a Receiver object within any returned ExternalObject. The Receiver manages the incoming AsyncIterable payloads and any requests for as yet unretrieved data. - use new type merging algorithm that lazily merges fields from additional subschemas as needed at field resolution time. - add __typename to all selection sets, but only once, needed because any type with deferred fields requires __typename
Configuration menu - View commit details
-
Copy full SHA for 3ba3682 - Browse repository at this point
Copy the full SHA 3ba3682View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb8b612 - Browse repository at this point
Copy the full SHA bb8b612View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae1e1f6 - Browse repository at this point
Copy the full SHA ae1e1f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b0f8fa - Browse repository at this point
Copy the full SHA 1b0f8faView commit details -
Precompile selection set hints into arrays of field nodes Dynamic selectionSet hints therefore now return an array of field nodes instead of a selectionSet!
Configuration menu - View commit details
-
Copy full SHA for 97ae0e7 - Browse repository at this point
Copy the full SHA 97ae0e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e8e39 - Browse repository at this point
Copy the full SHA 97e8e39View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc5988e - Browse repository at this point
Copy the full SHA bc5988eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04bcba5 - Browse repository at this point
Copy the full SHA 04bcba5View commit details -
generateProxyingResolvers should optionally take a transformedSchema …
…so that wrapSchema can be aware of the transformedSchema stitchSchemas was previously aware of this via StitchingInfo
Configuration menu - View commit details
-
Copy full SHA for 09d1b30 - Browse repository at this point
Copy the full SHA 09d1b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29f67e3 - Browse repository at this point
Copy the full SHA 29f67e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f8c63c - Browse repository at this point
Copy the full SHA 0f8c63cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f26739b - Browse repository at this point
Copy the full SHA f26739bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a4ce1a - Browse repository at this point
Copy the full SHA 9a4ce1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for aee792c - Browse repository at this point
Copy the full SHA aee792cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2874c6c - Browse repository at this point
Copy the full SHA 2874c6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3531495 - Browse repository at this point
Copy the full SHA 3531495View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e946d - Browse repository at this point
Copy the full SHA a9e946dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6609312 - Browse repository at this point
Copy the full SHA 6609312View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d6fe49 - Browse repository at this point
Copy the full SHA 0d6fe49View commit details -
Configuration menu - View commit details
-
Copy full SHA for c50a819 - Browse repository at this point
Copy the full SHA c50a819View commit details -
when possible, update the receiver synchronously rather than requesti…
…ng data from it not sure why (yet?), but it also helps some tests pass
Configuration menu - View commit details
-
Copy full SHA for 336a410 - Browse repository at this point
Copy the full SHA 336a410View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbb303c - Browse repository at this point
Copy the full SHA cbb303cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c083600 - Browse repository at this point
Copy the full SHA c083600View commit details -
implement mapAsyncIterator with repeaters
Implementation adapted from: repeaterjs/repeater#48 (comment) so that all payloads will be delivered in the original order
Configuration menu - View commit details
-
Copy full SHA for 30533c6 - Browse repository at this point
Copy the full SHA 30533c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b46a255 - Browse repository at this point
Copy the full SHA b46a255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c9e321 - Browse repository at this point
Copy the full SHA 1c9e321View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd17dd - Browse repository at this point
Copy the full SHA 5dd17ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83103bc - Browse repository at this point
Copy the full SHA 83103bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec4440f - Browse repository at this point
Copy the full SHA ec4440fView commit details -
change Receiver to emit graphql results instead of external objects
WIP, now emits results with merged errors, plan to emit plain results goal: create receivers that can be more easily modified for batching
Configuration menu - View commit details
-
Copy full SHA for e9e11d9 - Browse repository at this point
Copy the full SHA e9e11d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1faddee - Browse repository at this point
Copy the full SHA 1faddeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2153fb0 - Browse repository at this point
Copy the full SHA 2153fb0View commit details -
no longer necessary because createExternalObject creates a new object…
… rather than annotating
Configuration menu - View commit details
-
Copy full SHA for ec352cf - Browse repository at this point
Copy the full SHA ec352cfView commit details -
append base path to errors only when creating external values
this removes this logic from the receiver, which will help receiver proxying
Configuration menu - View commit details
-
Copy full SHA for 5bd77cb - Browse repository at this point
Copy the full SHA 5bd77cbView commit details -
stitch new base paths to errors only when creating leaf external valu…
…es, this allows the merged results to be agnostic of stitched base paths, and enables implementing batching of merged results irrespective of possible changes to the base paths
Configuration menu - View commit details
-
Copy full SHA for e84adb8 - Browse repository at this point
Copy the full SHA e84adb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 826e84b - Browse repository at this point
Copy the full SHA 826e84bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fcfc4f - Browse repository at this point
Copy the full SHA 0fcfc4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b18c428 - Browse repository at this point
Copy the full SHA b18c428View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfaea06 - Browse repository at this point
Copy the full SHA cfaea06View commit details -
Configuration menu - View commit details
-
Copy full SHA for c004429 - Browse repository at this point
Copy the full SHA c004429View commit details -
by splitting prior to externalValue creation we will be able to use the correct info
Configuration menu - View commit details
-
Copy full SHA for 489c9bf - Browse repository at this point
Copy the full SHA 489c9bfView commit details
Commits on Jun 1, 2021
-
We may end up having one type of Receiver Receivers can also return external values not just MergedExecutionResults, even if the cache is of MergedExecutionsResults
Configuration menu - View commit details
-
Copy full SHA for 99bda2d - Browse repository at this point
Copy the full SHA 99bda2dView commit details -
hew more closely to repeater js implementation
repeaterjs/repeater#48 (comment) add additional tests
Configuration menu - View commit details
-
Copy full SHA for df69614 - Browse repository at this point
Copy the full SHA df69614View commit details -
Receiver does not have to transform results
It can be passed a stream of transformedResults using mapAsyncIterator note that using `break` in for await(...of...) causes abrupt completion and will return the iterator, not really sure why this became a problem only when mapping the iterator
Configuration menu - View commit details
-
Copy full SHA for 97c0328 - Browse repository at this point
Copy the full SHA 97c0328View commit details -
refactor batchDelegateToSchema
...to use DataLoader for the actual GraphQL results, rather than the external values This allows us to properly transduce streams. TODO: 1. We should now be able to add the stream directive for batchDelegateToSchema. 2. Refactor error parsing, now we are relying on the onLocatedError option, but this is no longer necessary. Note that additional tests for batched errors are now passing (see #2951) 3. Bring back createBatchDelegateFn, that may be useful 4. The Receiver is now created separately for each list item, which means that the initialPathDepth probably does not match? This will require a separate argument to the Receiver constructor for adjustment 5. Bring back valuesFromResults and fix documentation, we now operate on GraphQL results, so should be fewer pitfalls (see #2829)
Configuration menu - View commit details
-
Copy full SHA for b844c3e - Browse repository at this point
Copy the full SHA b844c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aac856 - Browse repository at this point
Copy the full SHA 8aac856View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a079fc - Browse repository at this point
Copy the full SHA 3a079fcView commit details