Update mergeSchemas and delegation API, plus Schema Transfroms #527

freiksenet · 2017-12-08T15:06:21Z

This adds new API for delegation, that includes GraphQL Transforms.

Squashed commit of the following: commit a108877910e0556759f92e9acab4643c63be13ff Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Jan 31 16:05:00 2018 +0200 First transforms commit 334802c Merge: 99884b6 e9c0eb5 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Fri Jan 26 12:27:57 2018 +0200 Merge remote-tracking branch 'origin/master' into next-api commit 99884b6 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Fri Jan 26 11:57:15 2018 +0200 Restored valid fragments commit f1b2432 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Thu Jan 25 14:55:57 2018 +0200 Progress :P commit db2806a Author: Mikhail Novikov <freiksenet@gmail.com> Date: Thu Jan 25 13:35:35 2018 +0200 Fragment replacement commit e9c0eb5 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Jan 24 18:28:12 2018 +0200 v2.19.0 (#594) commit e33c215 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Jan 24 16:31:37 2018 +0200 Progress commit 464670f Author: Mikhail Novikov <freiksenet@gmail.com> Date: Tue Jan 23 15:03:40 2018 +0200 More progress commit 22d2295 Author: Sebastian Richter <sebastian.max.richter@gmail.com> Date: Tue Jan 23 12:45:49 2018 +0100 Also recreate astNode for fields (#580) * Also recreate astNode for fields In a [previous commit](fd9f626) we added the `astNode` property in the `reacreateCompositeType` function. That resulted in cache control working with schema stitching but only for GraphQL Types. By recreating the `astNode` prop also in `fieldToFieldConfig` cache control also works for fields. This is required for caching fields and hence queries. * Add ast to input field node too commit 03ad432 Author: Renato Benkendorf <renatobenks@users.noreply.github.com> Date: Tue Jan 23 08:35:00 2018 -0200 Fix resolvers to accept and move forward args with zero or false values (#586) Fixing the args with zero value or false commit 72ac16f Author: Mikhail Novikov <freiksenet@gmail.com> Date: Tue Jan 23 11:37:02 2018 +0200 Upgrade remap-istanbul (#590) commit 5420557 Merge: 24a0f3f 3ef557a Author: Sashko Stubailo <sashko@meteor.com> Date: Mon Jan 22 11:55:07 2018 -0800 Merge pull request #584 from shackpank/double_deps Remove graphql-subscriptions from devDependencies commit 3ef557a Author: Ollie Buck <git@olliebuck.com> Date: Fri Jan 19 14:40:03 2018 +0000 Remove graphql-subscriptions from devDependencies commit 7e4efe9 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Thu Jan 18 16:38:13 2018 +0200 Progress commit 24a0f3f Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Jan 10 12:36:43 2018 +0200 v2.18.0 (#574) commit 966e102 Author: Amit-A <Amit-A@users.noreply.github.com> Date: Wed Jan 10 02:53:56 2018 -0500 Fixing broken links (#573) commit 94b8f68 Author: Pascal Kaufmann <pozylon@gmail.com> Date: Tue Jan 9 12:51:53 2018 +0100 Fix fragment filtering edge case when a type implements multiple interfaces (#546) * add failing test for multi interface issue * interface / interface always implements an abstract type * changelog * the linter always should be happy * Update CHANGELOG.md commit 608414b Author: Tim Griesser <tgriesser10@gmail.com> Date: Tue Jan 9 06:15:12 2018 -0500 Allow IEnumResolver values to be number type (#568) * Allow IEnumResolver values to be number type commit 6177034 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Tue Jan 9 11:26:04 2018 +0200 v2.17.0 (#571) commit fd9f626 Author: Sebastian Richter <sebastian.max.richter@gmail.com> Date: Tue Jan 9 09:25:16 2018 +0100 Include astNode in schema recreation (#569) * Update schemaRecreation.ts `mergeSchemas` does not set `astNode` properties, when recreating types. But `CacheControlExtension.willResolveField` uses the `astNode` property in order to get the `cacheControl` directives. commit 4f489d3 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Jan 3 15:40:21 2018 +0200 v2.16.0 (#564) commit c4c5d91 Author: VimalRaj Selvam <email2vimalraj@gmail.com> Date: Wed Jan 3 19:00:16 2018 +0530 #544 - Update docs and tests to reflect new strings-as-descriptions pattern in new GraphQL SDL (#559) * #64 - Update docs and tests to reflect new strings-as-descriptions pattern in new GraphQL SDL * Make tests compatible with graphql v0.11 * Fix test errors * Remove extra space * Fix review comments commit 66d58bb Author: Alvis Tang <alvis@users.noreply.github.com> Date: Wed Jan 3 13:25:59 2018 +0000 fix: correct the dependency issue in typescript caused by #445 (#561) fix #472 commit 342bece Author: Johannes Schickling <schickling.j@gmail.com> Date: Wed Jan 3 14:21:35 2018 +0100 Add subscriptions support to `makeRemoteExectuableSchema` (#563) Added subscriptions support to makeRemoteExectuableSchema commit 8e8e348 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Tue Jan 2 14:50:06 2018 +0200 v2.15.0 (#562) commit f2905ac Author: Johannes Schickling <schickling.j@gmail.com> Date: Tue Jan 2 13:40:56 2018 +0100 Add document validation to `delegateToSchema` (#551) * Add document validation to `delegateToSchema` commit 59592e1 Merge: 3e24c69 3612216 Author: Sashko Stubailo <sashko@meteor.com> Date: Thu Dec 28 10:02:28 2017 -0800 Merge pull request #556 from enaqx/patch-4 doc: fix Generating schema URL on Mocking page commit 3612216 Author: Sashko Stubailo <sashko@meteor.com> Date: Thu Dec 28 10:00:16 2017 -0800 Update mocking.md commit 3e24c69 Merge: 7089bbf 42d180d Author: Sashko Stubailo <sashko@meteor.com> Date: Thu Dec 28 09:58:31 2017 -0800 Merge pull request #557 from tbroadley/fix-typos docs: fix typos commit 42d180d Merge: 5130cf6 7089bbf Author: Sashko Stubailo <sashko@meteor.com> Date: Thu Dec 28 09:57:11 2017 -0800 Merge branch 'master' into fix-typos commit 7089bbf Merge: 3a58286 5048434 Author: Sashko Stubailo <sashko@meteor.com> Date: Thu Dec 28 09:52:44 2017 -0800 Merge pull request #552 from mklopets/patch-2 Fix link to Apollo Link docs commit 5048434 Author: Marko Klopets <mklopets@users.noreply.github.com> Date: Thu Dec 28 14:23:07 2017 +0200 Re-fix link commit 5130cf6 Author: Thomas Broadley <buriedunderbooks@hotmail.com> Date: Mon Dec 25 17:45:44 2017 -0500 docs: fix typos commit 80f2f4c Author: Nick Raienko <enaqxx@gmail.com> Date: Mon Dec 25 09:19:03 2017 +0200 doc: fix Generating schema URL on Mocking page commit e295019 Author: Marko Klopets <mklopets@users.noreply.github.com> Date: Thu Dec 21 13:18:59 2017 +0200 Fix link to Apollo Link docs commit 3a58286 Merge: 259f22e 971e96e Author: Sashko Stubailo <sashko@meteor.com> Date: Wed Dec 20 11:26:55 2017 -0800 Merge pull request #548 from apollographql/create-2.14.1 v2.14.1 commit 971e96e Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Dec 20 12:44:14 2017 +0200 v2.14.1 commit 259f22e Author: Mikhail Novikov <freiksenet@gmail.com> Date: Wed Dec 20 12:42:16 2017 +0200 Guard against schemas without QueryType (#547) commit 1e3bb14 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Tue Dec 19 14:06:13 2017 +0200 Check null resolvers commit 2e2c9b1 Author: Mikhail Novikov <freiksenet@gmail.com> Date: Mon Dec 11 16:09:06 2017 +0200 Simplify API

stubailo · 2018-02-15T17:14:06Z

Todo:

Add test for calling delegateToSchema directly
Add a nice error for when the wrong number of arguments is passed, since that means people probably forgot to pass in the name of the schema
Documentation and blog post about transforms

stubailo · 2018-02-15T17:19:28Z

src/transforms/visitSchema.ts

+import { recreateType, createResolveType } from '../stitching/schemaRecreation';
+
+export enum VisitSchemaKind {
+  TYPE = 'VisitSchemaKind.TYPE',


Let's call this ANY_TYPE

stubailo · 2018-02-15T17:24:12Z

src/test/testTransforms.ts

+import { propertySchema } from './testingSchemas';
+import makeSimpleTransformSchema from '../transforms/makeSimpleTransformSchema';
+
+function RenameTypes(renameMap: { [originalName: string]: string }): Transform {


We could make this more general and also work for namespacing if this took a function instead of an object:

(type) => ({ oldName: 'newName' }[type]) (type) => ('NameSpace' + type)

stubailo · 2018-02-22T17:40:15Z

Proposed list of transforms:

Rename types
Rename fields
Select types/fields (opt-in)
(maybe) remove types/fields (opt-out)

sync · 2018-04-19T02:15:21Z

Can confirm that the problem with fragment into fragment we were experiencing is now fixed. Thank you once more.

freiksenet · 2018-04-19T09:15:48Z

Let's merge it folks @benjamn @stubailo

This implementation returns new objects only if modifications were made, and avoids defining/exporting a generic abstraction for functionality that was only used once.

Note that I have removed the sections about visitSchema and visitObject, since those utilities are no longer exported by the graphql-tools package.

martijnwalraven · 2018-04-21T07:29:22Z

This is great, happy to see we're getting close to a release! I know I haven't really been involved with this, so I'm a bit late to the party, but some questions that came up while looking at this:

Why do we export the built-in transforms under a Transforms object, instead of having people import them individually? Apart from the unusual capitalization, I feel it may draw too much of a distinction between built-in and custom transforms.
Since we're changing the API anyway here, would it make sense to try and come up with a better name than mergeInfo that we can also use to put additional utility methods on (like accessing a schema by name)? Maybe just utils or tools?

freiksenet · 2018-04-23T08:20:19Z

@martijnwalraven I'll change the transforms export. Our API is backwards compatible, so I think we are stuck with mergeInfo, I don't think it's worth a rename, esp if we have to keep compatability layer.

martijnwalraven · 2018-04-23T10:51:44Z

Oh, I thought we were changing the API from a mergeInfo closure argument to mergeInfo on info. I don't want to bikeshed this too much, but I'm afraid mergeInfo doesn't cover what we want to use this for so if we have an opportunity to fix it I think we should do that.

We'll probably want to add a resolveSchema method for instance, that resolves a schema by name. It seems weird for that to live on mergeInfo. What do you think of alternative names? I think something like tools or stitching makes the most sense to me.

freiksenet · 2018-04-23T12:44:09Z

Moved transform export to top level. Also added two transforms that a) were reported by users b) I needed for my blog post (:D)

benjamn · 2018-04-20T17:32:40Z

src/transforms/RenameTypes.ts

+    }
+
+    if (value && typeof value === 'object') {
+      const newObject = Object.create(Object.getPrototypeOf(value));


Note: I changed this code so that it now handles arrays as well as any other kind of object, preserving the original prototype. I think it's important to transform arrays as well as objects here, since you could have objects nested inside array results that need their __typenames to be updated.

benjamn · 2018-04-23T16:39:34Z

src/transforms/index.ts

+export { default as FilterRootFields } from './FilterRootFields';
+export { default as ExpandAbstractTypes } from './ExpandAbstractTypes';
+export { default as ExtractField } from './ExtractField';
+export { default as WrapQuery } from './WrapQuery';


I like this new style a lot better, thanks!

benjamn · 2018-04-23T16:48:59Z

src/stitching/delegateToSchema.ts

+  }
+
+  if (options.operation === 'subscription') {
+    // apply result processing ???


I forgot to submit a comment from a couple weeks ago (sorry), and this code has changed a bit since then, but I think the question is still relevant: is // apply result processing ??? an important TODO?

Since we're planning to bump the graphql-tools major version to 3.0.0, I think it's fine to hard-deprecate passing positional arguments to delegateToSchema, by throwing an exception rather than warning/continuing. There's no reason to keep using the old style, especially now that the fragmentReplacements argument has been replaced by transforms.

freiksenet force-pushed the next-api branch from dae909b to 2e2c9b1 Compare December 19, 2017 09:47

stubailo added the schema stitching label Dec 19, 2017

ecwyne mentioned this pull request Dec 19, 2017

Stitching causes errors when using graphql@0.12.x gramps-graphql/gramps--legacy#50

Closed

kbrandwijk mentioned this pull request Jan 11, 2018

Use with Schema Stitching gramps-graphql/gramps--legacy#71

Open

freiksenet mentioned this pull request Feb 15, 2018

Delegating to remote schema does not forward identical query? #633

Closed

freiksenet force-pushed the next-api branch from d9ae2df to 08e2058 Compare February 15, 2018 11:52

freiksenet added 3 commits February 15, 2018 14:15

mre from master

6f3728e

Merge remote-tracking branch 'origin/master' into next-api

9b18a78

Make all tests pass

0c1b48a

stubailo reviewed Feb 15, 2018

View reviewed changes

benjamn mentioned this pull request Feb 16, 2018

Abstraction for reusable schema @directive implementations. #640

Merged

5 tasks

freiksenet added 8 commits February 20, 2018 15:06

Namespacing schema

59d2779

Backwards compatible implementation

a0e8416

Alpha 6

4b108cb

More helpful warnings

a986cc9

Drop old versions

4fcd04b

Update dependencies

a21165d

Lock apollo-link to lower version to avoid their bug

1c0f3f8

Merge remote-tracking branch 'origin/master' into next-api

39f1d7a

freiksenet added 2 commits February 26, 2018 15:25

Richer onTypeConflict

f914bee

Alpha 7

65bd750

freiksenet mentioned this pull request Feb 27, 2018

mergeSchema - fragments don't query fields added during merge #605

Closed

freiksenet added 5 commits February 28, 2018 15:13

Filtering types

033efb5

Separate transforms

4a04136

Better

652d608

Fixed fragments

0988b01

Alpha 10

d0f8d3d

freiksenet mentioned this pull request Apr 18, 2018

createRequest with transforms API #724

Closed

1 task

freiksenet changed the title ~~Schema transforms, new mergeSchemas and everything~~ Update mergeSchemas and delegation API, plus Schema Transfroms Apr 18, 2018

Added Changelog

370e701

freiksenet force-pushed the next-api branch from 49dce99 to 370e701 Compare April 19, 2018 09:14

freiksenet added 3 commits April 20, 2018 10:28

Update schema-transforms.md

62972c3

Move everything to be a class

341a4ba

Make delegate to schema backwards compatible

f0219e0

freiksenet mentioned this pull request Apr 20, 2018

Fix error when merging schema without a query #746

Closed

5 tasks

freiksenet and others added 8 commits April 20, 2018 13:31

Merge branch 'master' into next-api

0e92f24

Minor tweaks to schema-delegation.md.

1116562

Editing pass over schema-stitching.md.

e3634d6

Define reusable IResolversParameterType.

193aaa6

Reimplement RenameTypes#transformResult without using visitObject.

dc5187f

This implementation returns new objects only if modifications were made, and avoids defining/exporting a generic abstraction for functionality that was only used once.

Rearrange and simplify v3.0.0 CHANGELOG.md section.

452586a

Editing pass over schema-transforms.md.

e5eb694

Note that I have removed the sections about visitSchema and visitObject, since those utilities are no longer exported by the graphql-tools package.

Rename Boolean (object) type annotations to boolean (primitive).

169e698

Remove qualified export, add wrapquery and extractfield

9b834b4

Merge branch 'master' into next-api

fa9af99

benjamn reviewed Apr 23, 2018

View reviewed changes

benjamn merged commit 4e68230 into master Apr 23, 2018

mfix22 mentioned this pull request May 2, 2018

Stitching schema without a Query shows "Query root type must be provided." #764

Closed

ardatan deleted the next-api branch April 2, 2020 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update mergeSchemas and delegation API, plus Schema Transfroms #527

Update mergeSchemas and delegation API, plus Schema Transfroms #527

freiksenet commented Dec 8, 2017 •

edited

Loading

stubailo commented Feb 15, 2018

stubailo Feb 15, 2018

stubailo Feb 15, 2018

stubailo commented Feb 22, 2018

sync commented Apr 19, 2018

freiksenet commented Apr 19, 2018

martijnwalraven commented Apr 21, 2018

freiksenet commented Apr 23, 2018

martijnwalraven commented Apr 23, 2018

freiksenet commented Apr 23, 2018

benjamn Apr 20, 2018 •

edited

Loading

benjamn Apr 23, 2018

benjamn Apr 23, 2018 •

edited

Loading

Update mergeSchemas and delegation API, plus Schema Transfroms #527

Update mergeSchemas and delegation API, plus Schema Transfroms #527

Conversation

freiksenet commented Dec 8, 2017 • edited Loading

stubailo commented Feb 15, 2018

stubailo Feb 15, 2018

Choose a reason for hiding this comment

stubailo Feb 15, 2018

Choose a reason for hiding this comment

stubailo commented Feb 22, 2018

sync commented Apr 19, 2018

freiksenet commented Apr 19, 2018

martijnwalraven commented Apr 21, 2018

freiksenet commented Apr 23, 2018

martijnwalraven commented Apr 23, 2018

freiksenet commented Apr 23, 2018

benjamn Apr 20, 2018 • edited Loading

Choose a reason for hiding this comment

benjamn Apr 23, 2018

Choose a reason for hiding this comment

benjamn Apr 23, 2018 • edited Loading

Choose a reason for hiding this comment

freiksenet commented Dec 8, 2017 •

edited

Loading

benjamn Apr 20, 2018 •

edited

Loading

benjamn Apr 23, 2018 •

edited

Loading