Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge lresolver objects in schema execution #612

Merged
merged 26 commits into from
Feb 5, 2018
Merged

Merge lresolver objects in schema execution #612

merged 26 commits into from
Feb 5, 2018

Conversation

freiksenet
Copy link
Contributor

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

Mike Fix and others added 26 commits January 10, 2018 18:29
Allow passing an array of resolver functions to makeExecutable schema
6587cc0 
- Closes #486
Implement passing an array of resolvers sets to mergeSchemas
454ff4b
Introduce unit or array composite type
0aff303
Fix @types dep
9c13517
Merge branch 'master' into mergeObjectsInSchemaExecution
210a0fa
@freiksenet
Merge branch 'master' into mergeObjectsInMergeSchemas
cb37c45
@freiksenet
Merge branch 'master' into mergeObjectsInSchemaExecution
cd71bbc
@renatobenks
Fix resolvers to accept and move forward args with zero or false valu…
9041bc2 
…es (#586)

Fixing the args with zero value or false
@BassT
Also recreate astNode for fields (#580)
57152af 
* Also recreate astNode for fields

In a [previous commit](fd9f626) we added the `astNode` property in the `reacreateCompositeType` function. That resulted in cache control working with schema stitching but only for GraphQL Types. By recreating the `astNode` prop also in `fieldToFieldConfig` cache control also works for fields. This is required for caching fields and hence queries.

* Add ast to input field node too
Address comments, remove lodash
66ddf7e
Merge branch 'master' into mergeObjectsInSchemaExecution
e2391ff
Fix @types dep
de31c04
@renatobenks
Fix resolvers to accept and move forward args with zero or false valu…
a6728b9 
…es (#586)

Fixing the args with zero value or false
@BassT
Also recreate astNode for fields (#580)
008935b 
* Also recreate astNode for fields

In a [previous commit](fd9f626) we added the `astNode` property in the `reacreateCompositeType` function. That resulted in cache control working with schema stitching but only for GraphQL Types. By recreating the `astNode` prop also in `fieldToFieldConfig` cache control also works for fields. This is required for caching fields and hence queries.

* Add ast to input field node too
Address comments, remove lodash
7977b06
Use mergeDeep instead of lodash.merge
e8631fd
Merge branch 'master' into mergeObjectsInMergeSchemas
4ffe3a7
Fix build
0c937ae
Merge branch 'master' into mergeObjectsInSchemaExecution
b4cc076
@freiksenet
Merge branch 'master' into mergeObjectsInSchemaExecution
48e8e49
@freiksenet
Merge branch 'master' into mergeObjectsInMergeSchemas
43f1297
@freiksenet
Merge branch 'master' into mergeObjectsInSchemaExecution
8704115
@freiksenet
Changelog and separate utility
9edfc6b
@freiksenet
Merge branch 'master' into mergeObjectsInMergeSchemas
1b78e09
@freiksenet
Merge branch 'mergeObjectsInMergeSchemas' of git://github.com/mfix22/…
b7b60a1 
…graphql-tools into mfix22-mergeObjectsInSchemaExecution
@freiksenet
Update CHANGELOG
a5a063e
@freiksenet freiksenet changed the title Mfix22 merge objects in schema execution Merge lresolver objects in schema execution Feb 5, 2018
@freiksenet freiksenet merged commit 4a01e32 into master Feb 5, 2018
@freiksenet freiksenet deleted the mfix22-mergeObjectsInSchemaExecution branch February 5, 2018 11:00
@dependencies dependencies bot mentioned this pull request Feb 5, 2018
Merged
@dependencies dependencies bot mentioned this pull request Feb 5, 2018
Closed
This was referenced Mar 14, 2018
Closed
Closed
Closed
@dependencies dependencies bot mentioned this pull request Mar 19, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freiksenet @renatobenks @BassT