Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #876, mirror delegateToSchema behavior for standalone #885

Merged
merged 4 commits into from
Jul 31, 2018

Conversation

Druotic
Copy link
Contributor

@Druotic Druotic commented Jul 12, 2018

See issue #876

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes). No consensus/input from others, but seems like an obvious choice.
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

/label bug
/label has-reproduction
/label schema-stitching

@ghost ghost added bug has-reproduction ❤ Has a reproduction in a codesandbox or single minimal repository schema-stitching labels Jul 12, 2018
@Druotic
Copy link
Contributor Author

Druotic commented Jul 25, 2018

This PR will continue to have conflicts with master due to the CHANGELOG file. Once this PR is reviewed, I'll resolve conflicts.

@stubailo stubailo merged commit b175a9f into ardatan:master Jul 31, 2018
@stubailo
Copy link
Contributor

Thank you for all the awesome PRs @Druotic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug has-reproduction ❤ Has a reproduction in a codesandbox or single minimal repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants