Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeSchema keeps ENUM description and deprecation #898

Merged
merged 7 commits into from
Jul 31, 2018

Conversation

chollier
Copy link
Contributor

mergeSchemas doesn't transpose enum description, this PR in a first time adds a failing test

@apollo-cla
Copy link

@chollier: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@chollier chollier changed the title Add a failing test for merging enum descriptions mergeSchema keeps ENUM description and deprecation Jul 18, 2018
@stubailo stubailo merged commit 84df7bd into ardatan:master Jul 31, 2018
@stubailo
Copy link
Contributor

Thanks a lot! This is a great bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants