Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #901: WrapQuery - add support for query wrapper to return selection set node. #902

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Fixes issue #901: WrapQuery - add support for query wrapper to return selection set node. #902

merged 3 commits into from
Jul 31, 2018

Conversation

Druotic
Copy link
Contributor

@Druotic Druotic commented Jul 24, 2018

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

See issue #901

@jjbeavers-lifeomic
Fixes issue ardatan#901: WrapQuery - add support for...
ff48b89 
query wrapper to return selection set node.
Docs - add example where WrapQuery query wrapper
function returns a SelectionSet.
@ghost ghost added docs Focuses on documentation changes feature New addition or enhancement to existing solutions labels Jul 24, 2018
@Druotic Druotic force-pushed the support-wrap-query-selection-set-return branch from 880bead to e5d71f4 Compare July 24, 2018 21:38
@Druotic
Copy link
Contributor Author

Druotic commented Jul 25, 2018

This PR will continue to have conflicts with master due to the CHANGELOG file. Once this PR is reviewed, I'll resolve conflicts.

@stubailo stubailo merged commit b1cc8da into ardatan:master Jul 31, 2018
@stubailo
Copy link
Contributor

Thanks for this PR, it's a useful feature for sure! And has minimal changes needed to the code, which is great

@dependencies dependencies bot mentioned this pull request Aug 2, 2018
Open
@hwillson hwillson mentioned this pull request Sep 7, 2018
Closed
@dependencies dependencies bot mentioned this pull request Oct 1, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Focuses on documentation changes feature New addition or enhancement to existing solutions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Druotic @stubailo @jjbeavers-lifeomic