Skip to content

Commit

Permalink
Merge pull request #84 from arduino-libraries/fix-compile-examples
Browse files Browse the repository at this point in the history
Fix size deltas report infrastructure configuration
  • Loading branch information
aentinger committed Feb 21, 2024
2 parents a27655e + 5ccad70 commit 5822766
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 23 deletions.
25 changes: 2 additions & 23 deletions .github/workflows/compile-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@ on:
workflow_dispatch:
repository_dispatch:

env:
# It's convenient to set variables for values used multiple times in the workflow.
SKETCHES_REPORTS_PATH: sketches-reports

jobs:
compile:
build:
name: ${{ matrix.board.fqbn }}
runs-on: ubuntu-latest

Expand All @@ -39,6 +35,7 @@ jobs:
UNIVERSAL_SKETCH_PATHS: |
- examples/SHA1
- examples/SHA256
SKETCHES_REPORTS_PATH: sketches-reports

strategy:
fail-fast: false
Expand Down Expand Up @@ -98,21 +95,3 @@ jobs:
if-no-files-found: error
path: ${{ env.SKETCHES_REPORTS_PATH }}
name: sketches-report-${{ matrix.board.artifact-name-suffix }}

# When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
report:
needs: compile # Wait for the compile job to finish to get the data for the report
if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
runs-on: ubuntu-latest

steps:
# This step is needed to get the size data produced by the compile jobs
- name: Download sketches reports artifacts
uses: actions/download-artifact@v4
with:
# All workflow artifacts will be downloaded to this location.
path: ${{ env.SKETCHES_REPORTS_PATH }}

- uses: arduino/report-size-deltas@v1
with:
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
25 changes: 25 additions & 0 deletions .github/workflows/report-size-deltas.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Report Size Deltas

# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
on:
push:
paths:
- ".github/workflows/report-size-deltas.yml"
schedule:
# Run at the minimum interval allowed by GitHub Actions.
# Note: GitHub Actions periodically has outages which result in workflow failures.
# In this event, the workflows will start passing again once the service recovers.
- cron: "*/5 * * * *"
workflow_dispatch:
repository_dispatch:

jobs:
report:
runs-on: ubuntu-latest

steps:
- name: Comment size deltas reports to PRs
uses: arduino/report-size-deltas@v1
with:
# Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow
sketches-reports-source: ^sketches-report-.+

0 comments on commit 5822766

Please sign in to comment.