[skip-changelog] Avoid getting locked up in a perpetual symlink loop when loading a library #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
MatteoPologruto
force-pushed
the
hang-on-symlink-library
branch
from
dd7c230
to
f872b0f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2146 +/- ##
==========================================
+ Coverage 62.55% 62.61% +0.06%
==========================================
Files 223 223
Lines 19459 19461 +2
==========================================
+ Hits 12172 12186 +14
+ Misses 6196 6188 -8
+ Partials 1091 1087 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
requested changes
Apr 19, 2023
MatteoPologruto
force-pushed
the
hang-on-symlink-library
branch
2 times, most recently
from
18ea391
to
b4aa009
Compare
MatteoPologruto
force-pushed
the
hang-on-symlink-library
branch
from
b4aa009
to
a34f57d
Compare
umbynos
approved these changes
May 3, 2023
cmaglie
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
When loading a library or sketch that contains multiple symlinks to a parent path, Arduino CLI locks up in a perpetual loop.
What is the new behavior?
Arduino CLI fails with an error when a symlink loop is encountered.
Does this PR introduce a breaking change, and is titled accordingly?
No