Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example file causing panic #752

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Fix example file causing panic #752

merged 3 commits into from
Jul 28, 2024

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 25, 2024

Having an example file in the library was causing the tool to panic, because it was being treated like a directory, but without checking if it was actually one.
The example file is just ignored now.
Close #751
The bug was discovered in arduino/library-registry#4836

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 25, 2024
@umbynos umbynos self-assigned this Jul 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (92436f3) to head (a4d7dd9).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          44       44           
  Lines        6800     6800           
=======================================
  Hits         6124     6124           
  Misses        553      553           
  Partials      123      123           
Flag Coverage Δ
unit 90.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
@per1234 per1234 added type: imperfection Perceived defect in any part of project and removed type: enhancement Proposed improvement labels Jul 28, 2024
@per1234 per1234 merged commit d5055cc into main Jul 28, 2024
89 checks passed
@per1234 per1234 deleted the example-not-folder branch July 28, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library with root example file is causing arduino-lint to crash
5 participants