Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tab if file is already open #119

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

murilopolese
Copy link
Contributor

Problem

When opening a file that is already open, you just got back to the editor on the previously active tab.
It should switch to the tab when this happens.

Solution

This following cases are considered:

  • Opening a file that is not already open: Open and make it the active tab
  • Opening a file that is already open: Make the already open tab active
  • Opening many files that are not open: Open and make the first file in the list the active tab
  • Opening many files that are already open: Make the first already open tab active
  • Open many files that are already open and not: Open files that are not open and make the first the active tab

@murilopolese murilopolese requested a review from ubidefeo April 23, 2024 15:37
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubidefeo ubidefeo merged commit d16a173 into development Apr 23, 2024
1 check passed
@ubidefeo ubidefeo deleted the bugfix/open-file branch April 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants