Extra resource #121
Merged
Extra resource #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubidefeo
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Windows and Linux, when packaged, the app lives inside an
asarfile.This causes issues getting the full path for the
helpers.pyfile to be executed.Solution
There are several ways to go around this issue.
I used electron builder's
extraResourcesto include thehelper.pyfile inside theresourcesfolder on the packaged app.This way the correct absolute path is resolved when the package is built.
Testing
The operations that use the helper are remove folder (from the board) and upload folder.
Probably needs some more extensive testing on MacOS.
It looks like it's working for Linux and Windows.